Use precompiled regular expressions to validate the segments of a UID

[joerg1985]

Description

Avoid to compile the SEGMENT_PATTERN for each validated segment of a UID.

Signed-off-by: Jörg Sautter joerg.sautter@gmx.net

[J-N-K]

Thanks! This looks like a nice improvement. It seems the pattern is also used at other places. I would suggest to make SEGMENT_PATTERN private instead of public and add a new method

public static boolean isValid(@Nullable String str) {
    return str != null && SEGMENT_PATTERN.matcher(str).matches();
}

You can then change the line in MetadataSelectorMatcher to

return result.stream().filter(AbstractUID::isValid).collect(Collectors.toSet());

[joerg1985]

@J-N-K the PR has been updated, as suggested. Thank you for the fast feedback / review!

[J-N-K]

Can you fix spotless:

Error:  Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.38.0:check (codestyle_check) on project org.openhab.core.io.rest.core: The following files had format violations:
Error:      src/main/java/org/openhab/core/io/rest/core/internal/item/MetadataSelectorMatcher.java
Error:          @@ -78,8 +78,7 @@
Error:           ············result.addAll(metadataNamespaces);
Error:           
Error:           ············//·filter·all·name·spaces·which·do·not·match·the·UID·segment·pattern·(this·will·be·the·regex·tokens):
Error:          -············return·result.stream().filter(AbstractUID::isValid)
Error:          -····················.collect(Collectors.toSet());
Error:          +············return·result.stream().filter(AbstractUID::isValid).collect(Collectors.toSet());
Error:           ········}
Error:           ····}
Error:           }
Error:  Run 'mvn spotless:apply' to fix these violations.
Error:  -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <args> -rf :org.openhab.core.io.rest.core
Error: Process completed with exit code 1.

[joerg1985]

@J-N-K Sorry for this, my local spotless is somehow broken.

mvn install will end in this error for me:

[ERROR] /pom.xml:[0]
Missing pom.xml file.
[WARNING] OH-INF.config.addons.xml:[0]
Unused configuration reference with uri - system:addons
[ERROR] null/pom.xml:[0]
Missing /project/version in the pom.xml file.
[ERROR] null/pom.xml:[0]
Missing /project/artifactId in the pom.xml file.

[J-N-K]

LGTM, thanks!