[rest] refactored the Stream2JSONInputStream to simplify the logic #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerg1985
force-pushed
the
SequenceInputStream
branch
2 times, most recently
from
376175d to
3e571d9
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/18 |
|
@J-N-K could you have a look at this one too? Thanks in advance |
J-N-K
requested changes
Mar 10, 2024
.../org.openhab.core.io.rest/src/main/java/org/openhab/core/io/rest/Stream2JSONInputStream.java
Outdated
Show resolved
Hide resolved
.../org.openhab.core.io.rest/src/main/java/org/openhab/core/io/rest/Stream2JSONInputStream.java
Outdated
Show resolved
Hide resolved
.../org.openhab.core.io.rest/src/main/java/org/openhab/core/io/rest/Stream2JSONInputStream.java
Outdated
Show resolved
Hide resolved
.../org.openhab.core.io.rest/src/main/java/org/openhab/core/io/rest/Stream2JSONInputStream.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jörg Sautter <joerg.sautter@gmx.net>
joerg1985
force-pushed
the
SequenceInputStream
branch
from
3e571d9 to
d51feb6
Compare
|
@J-N-K i have updated the PR, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will use the
SequenceInputStreamto simplify the logic for theStream2JSONInputStream.All interface methods can now be delegated to the
SequenceInputStream, this makes it easy to support methods like:public int read(byte @Nullable [] b, int off, int len) throws IOExceptionpublic long transferTo(OutputStream target) throws IOException