Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST] unitSymbol response for GroupItem #4106

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

mherwege
Copy link
Contributor

The item REST response does include a field unitSymbol for Number items, but not for Group items with Number base type. While the info can be retrieved by querying the metadata, it is easier in the UI to be able to use the same field.

This PR adds unitSymbol for Group items with base type Number in the REST response.

Required to avoid workaround for groups in openhab/openhab-webui#2312

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner February 22, 2024 11:57
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Mar 10, 2024
@J-N-K J-N-K added this to the 4.2 milestone Mar 10, 2024
@J-N-K J-N-K merged commit eeb6919 into openhab:main Mar 10, 2024
3 checks passed
@J-N-K J-N-K changed the title unitSymbol in REST response for GroupItem [REST] unitSymbol response for GroupItem Mar 10, 2024
@mherwege mherwege deleted the group_unitSymbol branch March 10, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants