Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SDDP IDENTIFY packets #4263

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

mlobstein
Copy link
Contributor

@mlobstein mlobstein commented May 31, 2024

The Atlona hdmi switch does not respond to SDDP SEARCH requests (although it periodically sends NOTIFY ALIVE packets). As an alternative it has a button in its web-ui that when pushed sends out a NOTIFY IDENTIFY packet that is the same the NOTIFY ALIVE packet, less the 'Max-Age' field. This PR changes SddpDiscoveryService to handle these packets as well.

reference (but not depended on by) openhab/openhab-addons#16832

NOTIFY IDENTIFY SDDP/1.0
From: "192.168.1.10:1902"
Host: "AT-UHD-PRO3-44M_B898B0030F4D"
Type: "AT-UHD-PRO3-44M"
Primary-Proxy: "avswitch"
Proxies: "avswitch"
Manufacturer: "Atlona"
Model: "AT-UHD-PRO3-44M"
Driver: "avswitch_Atlona_AT-UHD-PRO3-44M_IP.c4i"
Config-URL: "http://192.168.1.10/"

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein requested a review from a team as a code owner May 31, 2024 21:53
@wborn wborn added the enhancement An enhancement or new feature of the Core label Jun 1, 2024
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@wborn wborn merged commit 940a990 into openhab:main Jun 1, 2024
5 checks passed
@wborn wborn added this to the 4.2 milestone Jun 1, 2024
@mlobstein mlobstein deleted the sddp-identify branch July 1, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants