PersistenceExtensions: fix DateTimeException when persisting an empty TimeSeries #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TimeSeries Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
mherwege
approved these changes
Jul 8, 2024
|
LGTM |
holgerfriedrich
approved these changes
Jul 8, 2024
holgerfriedrich
added
the
bug
|
@jimtng - thanks! @holgerfriedrich - this should probably be cherry-picked into |
holgerfriedrich
pushed a commit
to holgerfriedrich/openhab-core
that referenced
this pull request
Jul 14, 2024
… TimeSeries (openhab#4303) Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
holgerfriedrich
pushed a commit
that referenced
this pull request
Jul 14, 2024
… TimeSeries (#4303) Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
Backport done. |
Can you also add the "patch" label? 🙂 |
holgerfriedrich
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression from #4298
When a TimeSeries is empty,
getBegin()andgetEnd()returnInstant.MAXandInstant.MINwhich when converted to a ZonedDateTime causes a DateTimeException