Fix merge of AddonInfo (masterAddonInfo field) #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows having translated label for bindings when showing list of installed bindings in Main UI parameters. Fix openhab/openhab-webui#2639 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Without the fix (look at the third column named "Add-on Settings"), no translation With the fix, labels are properly translated. |
J-N-K
reviewed
Jul 13, 2024
Comment on lines
+109
to
+110
| if (!a.isMasterAddonInfo() && b.isMasterAddonInfo()) { | ||
| builder.isMasterAddonInfo(true); |
There was a problem hiding this comment.
Why is it important that a is not masterAddonInfo?
There was a problem hiding this comment.
Just to avoid the useless call to builder.isMasterAddonInfo when the builder value is already set to true, and have a similar pattern as the remaining in that method.
But could also be done differently by replacing the full if then block by just:
builder.isMasterAddonInfo(a.isMasterAddonInfo() || b.isMasterAddonInfo()};
J-N-K
approved these changes
Jul 13, 2024
|
shall we backport this to 4.2.x? |
Would be appreciated. |
holgerfriedrich
pushed a commit
that referenced
this pull request
Jul 18, 2024
This fix allows having translated label for bindings when showing list of installed bindings in Main UI parameters. Fix openhab/openhab-webui#2639 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
holgerfriedrich
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows having translated label for bindings when showing list of installed bindings in Main UI parameters.
Fix openhab/openhab-webui#2639
Signed-off-by: Laurent Garnier lg.hc@free.fr