Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lists for metadata properties in items files #4330

Merged

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jul 24, 2024

I'm looking into adding a feature to the HomeKit add-on that is best implemented with array/list properties. I'm able to create arrays just fine in MainUI with the code editor, but it's not currently possible with file based items.

openhab/openhab-addons#17144 is the PR utilizing this feature.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer force-pushed the file-items-metadata-property-arrays branch from 1c4432f to c3fdd86 Compare July 25, 2024 16:38
@ccutrer ccutrer changed the title Support arrays for metadata properties in items files Support lsits for metadata properties in items files Jul 25, 2024
@ccutrer ccutrer changed the title Support lsits for metadata properties in items files Support lists for metadata properties in items files Jul 25, 2024
@ccutrer ccutrer marked this pull request as ready for review July 25, 2024 17:42
@ccutrer ccutrer requested a review from a team as a code owner July 25, 2024 17:42
@ccutrer
Copy link
Contributor Author

ccutrer commented Jul 25, 2024

cc @lsiepel

@ccutrer
Copy link
Contributor Author

ccutrer commented Jul 31, 2024

@openhab/core-maintainers : can I get a review please?

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 716045a into openhab:main Aug 5, 2024
5 checks passed
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Aug 5, 2024
@kaikreuzer kaikreuzer added this to the 4.3 milestone Aug 5, 2024
@ccutrer ccutrer deleted the file-items-metadata-property-arrays branch August 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants