Filter out blank lines and comments in a multi-line transformations #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/syntax-for-binding-transformations/157861/1 |
|
Given that JSON doesn't support comments do these comments survive the conversion between JSON to YAML and back to |
|
Yes, the comments will survive the json/yaml conversions, because they are part of the actual configuration data. |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
channeltransformation-comments
branch
from
a019111 to
5220147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to insert comments inbetween transformations in a multi-line / chained (or even a single transformation).
e.g.