Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameter of ChannelHandler #4361

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Rename parameter of ChannelHandler #4361

merged 1 commit into from
Aug 24, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Aug 23, 2024

@J-N-K did this get missed when moving from the http binding to core?

@jimtng
Rename parameter of ChannelHandler
143c415 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner August 23, 2024 02:37
J-N-K
J-N-K approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Seems a leftover, indeed.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Aug 24, 2024
@J-N-K J-N-K added this to the 4.3 milestone Aug 24, 2024
@J-N-K J-N-K merged commit 17ad247 into openhab:main Aug 24, 2024
5 checks passed
@jimtng jimtng deleted the channelhandler-arg-rename branch August 24, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jimtng @J-N-K