Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionInputsHelper: Add unit symbol to Quantity parameter description #4419

Closed
wants to merge 3 commits into from

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Oct 21, 2024

Useful for the UI.

florian-h05 and others added 3 commits October 21, 2024 14:10
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 marked this pull request as ready for review October 21, 2024 19:03
@florian-h05 florian-h05 requested a review from a team as a code owner October 21, 2024 19:03
@florian-h05
Copy link
Contributor Author

@J-N-K Can you please take a look at this minor change since you reviewed #4392?

@lolodomo
Copy link
Contributor

lolodomo commented Oct 22, 2024

Why do you want to mix-up description and unit ?
You have already the unit in a separate field.
So you can do what you want in UI side

@florian-h05
Copy link
Contributor Author

Since QuantityType is currently described as decimal parameter, the UI does not need to handle it in a special way and therefore does not use the unit field.
However, the user should know which unit he enters, and this IMO is more efficient handled in core.

@J-N-K
Copy link
Member

J-N-K commented Oct 22, 2024

I tend to agree with @lolodomo. Concatenating description and unit is as easy on client side as on server side. Depending on the UI (which may not only be MainUI), it would be better to have the description and unit separated.

@florian-h05
Copy link
Contributor Author

I will create a UI PR then 👍

@florian-h05 florian-h05 deleted the patch-1 branch October 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants