-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigDescriptionParameter: Change default format for datetime & Update context docs #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te context docs This changes the default format for the datetime context to the ISO standard. This context is not used by add-ons and supported by the UI, so it should be possible to change it (again after openhab#4392.) Also update the context docs from https://next.openhab.org/docs/developer/addons/config-xml.html#supported-contexts and the UI code. Signed-off-by: Florian Hotze <dev@florianhotze.com>
@lolodomo Let's change the format for the |
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 26, 2024
Closes openhab#2816. Depends on openhab/openhab-core#4428. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
J-N-K
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I agree, ISO date strings are more likely to be expected and used in this context. |
florian-h05
added a commit
to openhab/openhab-webui
that referenced
this pull request
Oct 26, 2024
Closes #2816. Depends on openhab/openhab-core#4428. --------- Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added a commit
to florian-h05/openhab-docs
that referenced
this pull request
Oct 27, 2024
Refs openhab/openhab-core#4428. Signed-off-by: Florian Hotze <dev@florianhotze.com>
stefan-hoehn
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Oct 27, 2024
Refs openhab/openhab-core#4428. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default format for the datetime context to the ISO standard. This context is not used by add-ons and supported by the UI, so it should be possible to change it (again after #4392.)
Also update the context docs from https://next.openhab.org/docs/developer/addons/config-xml.html#supported-contexts and the UI code.