Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigDescriptionParameter: Change default format for datetime & Update context docs #4428

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

florian-h05
Copy link
Contributor

This changes the default format for the datetime context to the ISO standard. This context is not used by add-ons and supported by the UI, so it should be possible to change it (again after #4392.)

Also update the context docs from https://next.openhab.org/docs/developer/addons/config-xml.html#supported-contexts and the UI code.

…te context docs

This changes the default format for the datetime context to the ISO standard.
This context is not used by add-ons and supported by the UI, so it should be possible to change it (again after openhab#4392.)

Also update the context docs from https://next.openhab.org/docs/developer/addons/config-xml.html#supported-contexts and the UI code.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from a team as a code owner October 26, 2024 13:03
@florian-h05
Copy link
Contributor Author

@lolodomo Let's change the format for the datetime context to use the ISO default format as this does not require to use a custom formatter anywhere that context is used.

florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Oct 26, 2024
Closes openhab#2816.
Depends on openhab/openhab-core#4428.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Oct 26, 2024
@J-N-K
Copy link
Member

J-N-K commented Oct 26, 2024

I agree, ISO date strings are more likely to be expected and used in this context.

@J-N-K J-N-K merged commit ae1f763 into openhab:main Oct 26, 2024
5 checks passed
@florian-h05 florian-h05 deleted the datetime-format branch October 26, 2024 18:48
@florian-h05 florian-h05 restored the datetime-format branch October 26, 2024 18:49
@florian-h05 florian-h05 deleted the datetime-format branch October 26, 2024 18:49
florian-h05 added a commit to openhab/openhab-webui that referenced this pull request Oct 26, 2024
Closes #2816.
Depends on openhab/openhab-core#4428.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05 added a commit to florian-h05/openhab-docs that referenced this pull request Oct 27, 2024
Refs openhab/openhab-core#4428.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
stefan-hoehn pushed a commit to openhab/openhab-docs that referenced this pull request Oct 27, 2024
Refs openhab/openhab-core#4428.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@wborn wborn added this to the 4.3 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants