[automation] ActionInputsHelper: Enable seconds for time & datetime #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me to enable seconds Refs openhab/openhab-webui#2848. Discussion in openhab/openhab-webui#2847 (comment). Signed-off-by: Florian Hotze <dev@florianhotze.com>
lolodomo
approved these changes
Nov 1, 2024
|
Once this is merged I will improve Instant and ZonedDateTime support to have the UI display it's dialog and not only a text box. |
|
@openhab/core-maintainers |
J-N-K
reviewed
Nov 5, 2024
| @@ -148,10 +151,12 @@ public ConfigDescriptionParameter mapActionInputToConfigDescriptionParameter(Inp | |||
| break; | |||
| case "java.time.LocalTime": | |||
| context = "time"; | |||
| step = BigDecimal.ONE; | |||
There was a problem hiding this comment.
what does one in this context mean? one second?
There was a problem hiding this comment.
Exactly.
The step size for datetime and time contexts defaults to 60 seconds, setting it to 1 second enables them to display seconds as well.
For reference: openhab/openhab-webui#2848.
J-N-K
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the step size to 1 for time and datetime, seconds are enabled in the UI.
Refs openhab/openhab-webui#2848.
Discussion in openhab/openhab-webui#2847 (comment)