Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment2 kongadeline #4511

Closed
wants to merge 3 commits into from

Conversation

iamAden
Copy link

@iamAden iamAden commented Dec 21, 2024

  1. The addressed component/module/part of the system (1 mark)
  • For ImperialUnits.java, support for " (inches) and ' (feet) was added as valid units for measurements. This change resolves issue support " and ' as a valid units for inches and feet #3551.
  • For QuantityTypeTest.java, added new test methods (testUnitAliases and testFormattedUnits) to validate the changes in ImperialUnits.java and ensure that the parsing and formatting of these units work correctly.
  • Removing unused variable BIG_DECIMAL_2 in ColorUtil.java was addressed as part of corrective maintenance.
  1. The graph you created and its completeness (3 marks)
    Screenshot 2024-12-21 233831

  2. The impact or insights gained from the analysis (1 mark)

  • Adding " and ' as valid units enhances usability and aligns with user expectations for measurement systems. The new test methods verify that the added units (" and ') are correctly parsed and formatted. This ensures robustness for the new feature. The removal of BIG_DECIMAL_2 streamlines ColorUtil.java and reduces potential confusion or maintenance overhead.

@iamAden iamAden requested a review from a team as a code owner December 21, 2024 15:40
@iamAden iamAden closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant