Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sharedCache and privateCache to file-based RulesDSL #4525

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Add sharedCache and privateCache to file-based RulesDSL #4525

merged 1 commit into from
Dec 31, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Dec 28, 2024

Fix #4447

@jimtng
Add sharedCache and privateCache to file-based RulesDSL
94463b2 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner December 28, 2024 14:44
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-3-release-discussion/160888/213

holgerfriedrich
holgerfriedrich approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This now matches the docs https://www.openhab.org/docs/configuration/jsr223.html#dsl, but still we have some contradicting docs here: https://next.openhab.org/docs/tutorial/rules_advanced.html (there just cache is used, which is at least wrong for DSL).

@holgerfriedrich holgerfriedrich merged commit 321d3a5 into openhab:main Dec 31, 2024
3 checks passed
@holgerfriedrich holgerfriedrich added the bug An unexpected problem or unintended behavior of the Core label Dec 31, 2024
@holgerfriedrich holgerfriedrich added this to the 5.0 milestone Dec 31, 2024
@jimtng jimtng deleted the dsl-valuecache branch December 31, 2024 12:56
@jimtng
Copy link
Contributor Author

jimtng commented Jan 1, 2025

Should this be backported?

@jimtng
Copy link
Contributor Author

jimtng commented Jan 1, 2025

we have some contradicting docs here: https://next.openhab.org/docs/tutorial/rules_advanced.html (there just cache is used, which is at least wrong for DSL).

This is for JavaScript, so it's indeed cache, not sharedCache.

I will submit some minor fixes to the docs, but they are not related to this PR. I only noticed that while reading the linked docs.

holgerfriedrich pushed a commit that referenced this pull request Jan 7, 2025
@jimtng @holgerfriedrich
Add sharedCache and privateCache to file-based RulesDSL (#4525)
5abf4fb 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@holgerfriedrich holgerfriedrich added the patch A PR that has been cherry-picked to a patch release branch label Jan 7, 2025
@holgerfriedrich
Copy link
Member

as it is working on 5.x, backported to 4.3.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

sharedCache broken for rules DSL
3 participants
@jimtng @openhab-bot @holgerfriedrich