Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config normalization in addon configuration #4528

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Dec 30, 2024

Reported on the forum. When installing add-ons from the marketplace the config-description could not be found because a wrong uid was used when retrieving it. As a result the configuration was not normalized and all numeric values were converted to a Doubleinstead of the correct type.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Dec 30, 2024
@J-N-K J-N-K requested a review from a team as a code owner December 30, 2024 20:58
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/matter-binding/161138/26

@digitaldan
Copy link
Contributor

Thanks @J-N-K !

I would vote to back port this to 4.3.x

Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich holgerfriedrich merged commit fe730b3 into openhab:main Dec 31, 2024
3 checks passed
@holgerfriedrich holgerfriedrich added this to the 5.0 milestone Dec 31, 2024
holgerfriedrich pushed a commit that referenced this pull request Dec 31, 2024
Signed-off-by: Jan N. Klug <github@klug.nrw>
@holgerfriedrich holgerfriedrich added the patch A PR that has been cherry-picked to a patch release branch label Dec 31, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/aeotec-z-wave-controller-gen7-working-with-openhab/161284/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants