Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[websocket] Change EventWebSocketAdapter adapter id to events #4540

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jan 4, 2025

This is aligns the event WS name with the SSE events endpoint.
This is a breaking change for clients that have explicitly used /ws/event-subscriber instead of the default /ws, but this wasn’t documented so has very likely not been used that way.

This is aligns the event WS name with the SSE events endpoint.
This is a breaking change for clients that have explicitly used `/ws/event-subscriber` instead of the default `/ws`.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from a team as a code owner January 4, 2025 20:48
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Jan 4, 2025
Depends on openhab/openhab-core#4540.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Jan 6, 2025
@kaikreuzer kaikreuzer merged commit f8fdd66 into openhab:main Jan 6, 2025
2 checks passed
@florian-h05 florian-h05 deleted the event-websocket-name branch January 6, 2025 18:58
florian-h05 added a commit to openhab/openhab-webui that referenced this pull request Jan 6, 2025
Depends on openhab/openhab-core#4540.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@kaikreuzer kaikreuzer added this to the 5.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants