Ensure sitemap subscriptions are updated on Group Items #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
holgerfriedrich
pushed a commit
that referenced
this pull request
Jan 11, 2025
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
holgerfriedrich
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where sitemaps containing group items that change, only update when a subscription times out (30 seconds)
I noticed while troubleshooting our IOS client that the sitemap i use for the apple watch would not update in realtime, only every 30 seconds. Turns out this sitemap only has group items, and our SitemapResource was not subscribing to those events. This is a pretty small change, i would recommend to back port as well.