Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntervalConditionHandler #4583

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 1, 2025

This condition handler limits how often the rule executes.

Main UI support openhab/openhab-webui#3049
Self note: documentation - To be done after the acceptance of PR

@jimtng jimtng requested a review from a team as a code owner February 1, 2025 11:21
@jimtng jimtng force-pushed the interval-condition branch from 53e6ebd to 474adab Compare February 1, 2025 11:27
@jimtng jimtng marked this pull request as draft February 1, 2025 12:04
@jimtng jimtng force-pushed the interval-condition branch 3 times, most recently from eb1ecd5 to 1b811bc Compare February 1, 2025 14:07
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the interval-condition branch from 1b811bc to fed3bc1 Compare February 1, 2025 14:14
@jimtng jimtng marked this pull request as ready for review February 1, 2025 23:09
@rkoshak
Copy link

rkoshak commented Feb 4, 2025

Do the helper libraries for the various languages need an update too?

@jimtng
Copy link
Contributor Author

jimtng commented Feb 4, 2025

Jruby already has this feature (this was in fact an idea taken from it)

I'm not sure how it works in jsscripting but I can take a look if this pr is merged

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 7177759 into openhab:main Feb 15, 2025
2 checks passed
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Feb 15, 2025
@kaikreuzer kaikreuzer added this to the 5.0 milestone Feb 15, 2025
@jimtng jimtng deleted the interval-condition branch February 15, 2025 23:58
florian-h05 pushed a commit to openhab/openhab-webui that referenced this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants