[semantics] Specified service for component description

[cweitkamp]

• Specified service for component description
• Implement ItemRegistryChangeListener interface instead of RegistryChangeListener<Item>

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

[kaikreuzer]

Thanks for this fix!

Could you briefly explain why this resolves the circular reference?
And registering the service as a MetaDataProvider, does it mean that this was lost when removing the xmls (and thus the whole service wasn't working?)

[cweitkamp]

I have to admit, that I am not sure if it will resolve the circular reference. I tried to identify it but I could not find it. If it really exists the construction injection changes will reveal it. Maybe there is another consumer involved which is not part of OHC. I will ask @digitaldan about it and remove the magic words from my OP.

MetadataProvider (SemanticsMetadataProvider) -->
(1..1) ItemRegistry (ItemRegistryImpl) -->
(1..1) MetadataRegistry (MetadataRegistryImpl) -->
(optional, dynamic) ManagedMetadataProvider (ManagedMetadataProviderImpl) -->
(1..1) StorageService ...

What caught my attention was this message. SCR created a service for the RegistryChangeListener - which is not supposed to be registered as a service - I guess. The specific declaration now takes care of that.

{org.eclipse.smarthome.core.items.MetadataProvider, org.eclipse.smarthome.core.common.registry.RegistryChangeListener}={service.id=256, service.bundleid=186, service.scope=bundle, component.name=org.eclipse.smarthome.core.semantics.internal.SemanticsMetadataProvider, component.id=134}

I am afraid I cannot tell you if something got lost back then. The initial contribution (eclipse-archived/smarthome#6288) already used DS annotations.

[kaikreuzer]

Thanks, sounds all reasonable!