Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsondb for ESH to OH namespace changes #1057

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 11, 2020

Related to openhab/openhab-core#1290.


I haven't tested this myself yet. :-)

Signed-off-by: Wouter Born <github@maindrain.net>
REPLACE;org.eclipse.smarthome.core;org.openhab.core;$OPENHAB_USERDATA/jsondb/org.openhab.core.thing.Thing.json
REPLACE;org.eclipse.smarthome;org.openhab.core;$OPENHAB_USERDATA/jsondb/org.openhab.core.thing.Thing.json

DELETE;$OPENHAB_USERDATA/jsondb/org.eclipse.smarthome.core.thing.link.ItemThingLink.json
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files have been unused for quite some time now (see eclipse-archived/smarthome#4102).

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. I had this on my to-do list too.

Should we consider the jsondb/backup/ folder too?

@wborn
Copy link
Member Author

wborn commented Jan 12, 2020

Should we consider the jsondb/backup/ folder too?

I'd prefer to leave them alone. They are backups for a reason so preferably they shouldn't be modified. It'll also be difficult to patch them using the current update commands because each backup has a different epoch timestamp in the filename.

@cweitkamp cweitkamp merged commit ad3afa0 into openhab:master Jan 13, 2020
@wborn wborn deleted the jsondb-esh-oh branch January 13, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants