Use XML instead of properties file for log4j2 configuration #1078
Conversation
Note that Karaf processes the log4j2 configuration to add the sshd logger and this processing of XML elements is case sensitive. It will throw exceptions if lower case element names are used or when the root logger is at the end of the list of loggers. When new loggers are added, the XML configuration is serialized such that: * The <Configuration> element is added to the same line as the <?xml> element * Attributes are sorted so therefor the 'name' is at the end of the appender/logger lines Related to openhab#516 Signed-off-by: Wouter Born <github@maindrain.net>
|
I guess this will also require some documentation updates. |
|
I've created openhab/openhab-docs#1163 for this. Do you think we should also replace Logback with Log4j2 for OH3 development/tests? It might be easier to configure logging when users/contributors are already familiar with the log4j2 XML syntax when it is also used by the OH3 distro. Since log4j2 is more feature rich (complex) it may impact build times. Log4j2 probably also has more/bigger dependencies/artifacts. I do not know the exact reasons why Logback is currently used during development. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/logging-in-openhab-3/105784/3 |
|
Logback is currently used because openHAB used to use logback from the beginning. |
Note that Karaf processes the log4j2 configuration to add the sshd logger and this processing of XML elements is case sensitive.
It will throw exceptions if lower case element names are used or when the root logger is at the end of the list of loggers.
When new loggers are added, the XML configuration is serialized such that:
<Configuration>element is added to the same line as the<?xml>elementRelated to #516
Including other configuration files still results in issues (see: #516 (comment)).