Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java 11 nashorn.args #1117

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Jun 22, 2020

They cause issues when used with Java 8.

Fixes openhab/openhab-addons#7880

They cause issues when used with Java 8.

Fixes openhab/openhab-addons#7880

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team June 22, 2020 07:24
@kaikreuzer
Copy link
Member

Interesting. How can this setting have such an impact...?

@wborn
Copy link
Member Author

wborn commented Jun 22, 2020

Yes I also thought it would be pretty harmless when used with Java 8.
But it seems to panic when it doesn't know what to do with it. 😞

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for analyzing and fixing it so quickly!

@kaikreuzer kaikreuzer merged commit 77ebddf into openhab:2.5.x Jun 22, 2020
@wborn wborn deleted the remove-java11-nashorn-args branch June 22, 2020 07:33
@helmar74
Copy link

Hi,

how could I solve the issue in my Openhab 2.5.6 environment? (Updated today)

Thanks a lot

@wborn
Copy link
Member Author

wborn commented Jun 22, 2020

Remove the line from the runtime/bin/setenv(.bat) script as you can see in the changes.

@helmar74
Copy link

ok, do I have to stop OH before and restart after the change?

@wborn
Copy link
Member Author

wborn commented Jun 22, 2020

It doesn't really matter because the file is only read at startup. Just make the change and restart openHAB.

@kaikreuzer
Copy link
Member

kaikreuzer commented Jun 22, 2020

Tested latest distro and I can confirm that it solves the issue, thanks!
I'll probably make sense to just do a new 2.5.6 distro binary with that as none of the add-ons have changed.

@BClark09
Copy link
Member

Hi @kaikreuzer, have you started the new build? I'll make sure to build 2.5.6-2 for the APT and YUM repos and then manually delete 2.5.6-1, this way people who have already updated can update again.

@kaikreuzer
Copy link
Member

Yes, just uploading the distro to Bintray (https://ci.openhab.org/view/Release%20Jobs/job/openhab-release/85), should be finishing soon.
If you can deal with the linux package update to 2.5.6-2, it would be great, thanks!

@kaikreuzer
Copy link
Member

Distro is on Bintray. @BClark09, you can go ahead!

@BClark09
Copy link
Member

Thanks again Kai, done and available on APT/YUM repos now :)

We can delete 2.5.6-1 at a later time.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-2-5-x-patch-releases/90248/246

@helmar74
Copy link

Updated to 2.5.6-2, issue is fixed.

Thanks a lot

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/error-while-executing-background-thread-http-refresh-service-after-upgrade-to-2-5-6-1/101165/5

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/rule-not-working-after-update-to-2-5-6-2/101248/12

1 similar comment
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/rule-not-working-after-update-to-2-5-6-2/101248/12

@DerOetzi
Copy link

Was the docker image 2.5.6 rebuilt after this fix, because I cannot find this line inside my test instance?

@wborn
Copy link
Member Author

wborn commented Jun 24, 2020

Yes it was. That means you're using an up to date image. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JS transformation] NPE in JavaScriptEngineManager when getting Javascript Engine
6 participants