-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Java 11 nashorn.args #1117
Conversation
They cause issues when used with Java 8. Fixes openhab/openhab-addons#7880 Signed-off-by: Wouter Born <github@maindrain.net>
Interesting. How can this setting have such an impact...? |
Yes I also thought it would be pretty harmless when used with Java 8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for analyzing and fixing it so quickly!
Hi, how could I solve the issue in my Openhab 2.5.6 environment? (Updated today) Thanks a lot |
Remove the line from the |
ok, do I have to stop OH before and restart after the change? |
It doesn't really matter because the file is only read at startup. Just make the change and restart openHAB. |
Tested latest distro and I can confirm that it solves the issue, thanks! |
Hi @kaikreuzer, have you started the new build? I'll make sure to build 2.5.6-2 for the APT and YUM repos and then manually delete 2.5.6-1, this way people who have already updated can update again. |
Yes, just uploading the distro to Bintray (https://ci.openhab.org/view/Release%20Jobs/job/openhab-release/85), should be finishing soon. |
Distro is on Bintray. @BClark09, you can go ahead! |
Thanks again Kai, done and available on APT/YUM repos now :) We can delete 2.5.6-1 at a later time. |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-2-5-x-patch-releases/90248/246 |
Updated to 2.5.6-2, issue is fixed. Thanks a lot |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/rule-not-working-after-update-to-2-5-6-2/101248/12 |
1 similar comment
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/rule-not-working-after-update-to-2-5-6-2/101248/12 |
Was the docker image 2.5.6 rebuilt after this fix, because I cannot find this line inside my test instance? |
Yes it was. That means you're using an up to date image. :-) |
They cause issues when used with Java 8.
Fixes openhab/openhab-addons#7880