Apply spotless formatter after changes

[kaikreuzer]

Related to openhab/openhab-addons#8401

Signed-off-by: Kai Kreuzer kai@openhab.org

[wborn]

Let's test if it fixes the sandbox build.

[kaikreuzer]

Looks much better, but for some reason the webui build failed when running spotless, see https://ci.openhab.org/view/Sandbox/job/sandbox-openhab2-release/1640/console.

Locally, I see no issue with that. Do you have any idea what might be wrong there?

[wborn]

Yes it's the 2.5.x branch for which spotless was never activated.
It only got added on the master branch with openhab/openhab-webui#240.

[kaikreuzer]

Good point, I accidentally checked the master branch only.
I've created openhab/openhab-webui#335, which should hopefully address the issue.

[kaikreuzer]

Hooray, it is green again: https://ci.openhab.org/job/sandbox-openhab2-release/1647/

[wborn]

That's great so we can deliver 2.5.9 on time and proceed with porting the add-ons!

Will this also commit the applied Spotless changes to the repo?

When the previous successful pre-Spotless build was still there, it looked like running the Spotless check goal in the new builds had a significant impact on the build time of all the "Prepare next version" stages.
That could be reduced by adding -Dspotless.check.skip=true to some of the Maven commands.

[wborn]

If I compare the stage views between openhab-release and sandbox-openhab2-release the increase seems less significant. It may also have been some Jenkins glitch.

[kaikreuzer]

Will this also commit the applied Spotless changes to the repo?

I'd think so, yes. We will see with the 2.5.9 release :-)

[wborn]

The Jenkinsfile also needs to be updated on the master branch to be able to release OH3. Since it did not commit the changes to the repo, adding -Dspotless.check.skip=true would yield the same result but faster. ;-)

[kaikreuzer]

I've created #1154 - let's see how well that works.