Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds a new logger to our default log configuration that can be utilized by user provided scripts. #1340

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

digitaldan
Copy link
Contributor

@digitaldan digitaldan commented Dec 5, 2021

The JSScripting rules binding will be introducing nodejs compatible logging, so console.log, console.debug, console.error and so on. This PR adds a default namespace for user script logging which can be used by JSScripting as well as any other scripting engine. The only messages logged using this namespace will be provided by users, which is why its severity level is set as it is.

See openhab/openhab-addons#11656 for the corresponding changes to the JSScripting binding.

Signed-off-by: Dan Cunningham dan@digitaldan.com

…tilized by user provided scripts.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan digitaldan requested a review from a team as a code owner December 5, 2021 00:03
@digitaldan digitaldan mentioned this pull request Dec 5, 2021
8 tasks
@kaikreuzer kaikreuzer merged commit 31a6a46 into openhab:main Dec 5, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Dec 5, 2021
@digitaldan
Copy link
Contributor Author

👍

@digitaldan digitaldan deleted the script-logger branch December 5, 2021 17:06
digitaldan added a commit to digitaldan/openhab-distro that referenced this pull request Jan 17, 2022
…can be utilized by user provided scripts. (openhab#1340)"

This reverts commit 31a6a46.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
kaikreuzer pushed a commit that referenced this pull request Jan 17, 2022
…can be utilized by user provided scripts. (#1340)" (#1364)

This reverts commit 31a6a46.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants