Upgrade minimum JDK to 17 #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
requested changes
Dec 10, 2022
wborn
requested changes
Dec 19, 2022
There was a problem hiding this comment.
I think this might also be a PR that can remove --no-deprecation-warning 🙂
openhab-distro/launch/app/app.bndrun
Line 81 in 466a342
Then I can use it here openhab/openhab-addons#14013 (comment)
wborn
requested changes
Dec 19, 2022
There was a problem hiding this comment.
This can also use an update.
openhab-distro/launch/app/app.bndrun
Line 72 in 466a342
And you'll probably need to reresolve the runbundles because of all the other dependency changes, you can do that on the CLI without Eclipse.
Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
requested changes
Dec 19, 2022
There was a problem hiding this comment.
There's still something to do:
- Remove:
openhab-distro/launch/app/app.bndrun
Line 81 in 466a342
Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
added
rebuild
wborn
added a commit
to wborn/openhab-distro
that referenced
this pull request
Dec 20, 2022
Related to openhab#1432 Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer
pushed a commit
that referenced
this pull request
Dec 20, 2022
Related to #1432 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added a commit
to wborn/openhab-distro
that referenced
this pull request
Dec 22, 2022
Related to openhab#1432 Signed-off-by: Wouter Born <github@maindrain.net>
Merged
kaikreuzer
pushed a commit
that referenced
this pull request
Dec 22, 2022
Related to #1432 Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openhab/openhab-core#2994
Signed-off-by: Jan N. Klug github@klug.nrw