Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenWeatherMap binding to features #806

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

cweitkamp
Copy link
Contributor

  • Added OpenWeatherMap binding to features

Depends on eclipse-archived/smarthome#5694.

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very proactive ;-)
We just have to wait for the CQ approval...

@martinvw martinvw merged commit 4f35a42 into openhab:master Nov 14, 2018
@kaikreuzer
Copy link
Member

@martinvw That was too quick! You'll have to wait until there's a successful ESH stable build.
I just tried to do one, but it failed, see eclipse-archived/smarthome#5694 (comment).

@martinvw
Copy link
Member

O o, that is indeed my local build problem as well.

@martinvw
Copy link
Member

We just have to wait for the CQ approval...

That was past, so I thought that those were all preconditions ... So I now broke 2 builds...

@martinvw
Copy link
Member

@kaikreuzer shall we / I revert it?

@kaikreuzer
Copy link
Member

Depends on how quickly it might be fixed.

@martinvw
Copy link
Member

Is this officially fixed by now? Or should I keep it on my todo/watch list? Anything I could do for it?

And are you already completely up and running again? 'Beterschap'!

@cweitkamp cweitkamp deleted the feature-openweathermap-binding branch November 16, 2018 19:13
@cweitkamp
Copy link
Contributor Author

Yes, it is. Everything is working fine again and we have a new and fully functional ESH build again since yesterday afternoon.

@wborn wborn added this to the 2.4 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants