replaced ESH features by the new openHAB Core features in the distro #863
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
| <groupId>org.eclipse.smarthome</groupId> | ||
| <artifactId>esh-core</artifactId> | ||
| <version>${esh.version}</version> | ||
| <groupId>org.openhab.core.features.karaf</groupId> |
There was a problem hiding this comment.
@maggu2810 Once again, I have to ask for your help on some Karaf issue:
As you can see in the PR build, when creating the distro feature the versions for jna and jetty seem to be lost (which are defined in the parent pom(s)). When I remove the dependency to the new org.openhab.core.features.karaf.openhab-core feature here, everything works (as before). I have no clue, why this dependency can make such a difference...
There are also warnings in the log:
[WARNING] Manifest not present in the first entry of the zip - org.openhab.core.bom.openhab-core-2.5.0-SNAPSHOT.pom
[WARNING] Manifest not present in the first entry of the zip - org.openhab.core.bom.test-2.5.0-SNAPSHOT.pom
Maybe this is somehow related?
There was a problem hiding this comment.
Ah - forget it, I found the issue! PR for openhab-core is coming...
There was a problem hiding this comment.
Sorry, same here. Didn't see that notification.
There was a problem hiding this comment.
No worries, you see that I was able to help myself :-)
|
Requires openhab/openhab-core#547 to work. |
kaikreuzer
added
rebuild
|
Hooray! Thanks for merging so quickly! |
Signed-off-by: Kai Kreuzer kai@openhab.org