Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use gosu instead of sudo #13

Closed
wants to merge 1 commit into from
Closed

Conversation

cyberkov
Copy link
Member

Hello!

According to the Dockerfile Best Practices one should use gosu instead of sudo to circumvent problems arising with apparmor on the host system.
I prepared a test image on dockerhub for x86: docker pull cyberkov/openhab2:gosu to try it out.
Unfortunately I cannot reproduce the problem on Debian Jessie yet, so I would be glad if someone could verify it.
This should fix #12

Cheers
Hannes

@danbo
Copy link

danbo commented Jul 15, 2016

I ran into #12 when trying the official image. I tried yours and can confirm I'm no longer seeing the problem.

I'm running Ubuntu 14 LTS as the docker host.

@cniweb
Copy link
Member

cniweb commented Nov 7, 2016

@cyberkov Can you resolve the conflicts, please?

@cyberkov
Copy link
Member Author

cyberkov commented Nov 9, 2016

Hello!

Yes. I look into it.

Cheers Hannes

@legacycode
Copy link
Contributor

I have tested the gosu branch from cyberkov on ubuntu 14.04 and debian jessie. The branch works on both systems. I used following compose file:

openhab2:
  image: "openhab/gosu"
  net: host
  volumes:
    - "/etc/localtime:/etc/localtime:ro"
    - "/etc/timezone:/etc/timezone:ro"
    - "/opt/gosu/userdata:/openhab/userdata"
    - "/opt/gosu/conf:/openhab/conf"
  environment:
    OPENHAB_HTTP_PORT: "6080"
    OPENHAB_HTTPS_PORT: "6443"
  command: "server"
Distributor ID: Ubuntu (works)
Description:    Ubuntu 14.04.5 LTS
Release:        14.04
Codename:       trusty
Docker version 1.12.3, build 6b644ec
docker-compose version 1.7.1, build 0a9ab35
Distributor ID: Debian (works)
Description:    Debian GNU/Linux 8.6 (jessie)
Release:        8.6
Codename:       jessie
Docker version 1.12.5, build 7392c3b
docker-compose version 1.9.0, build 2585387

@legacycode
Copy link
Contributor

I created a new pull request #43 resolving the conflicts.

@cyberkov cyberkov closed this Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entrypoint.sh uses sudo
4 participants