Stop suggesting proxy_buffering for openHAB-nginx settings #115
Comments
BClark09
changed the title
ThomDietrich
pushed a commit
that referenced
this issue
Nov 2, 2016
SSEs are now supported through a proxy using buffering. IMHO we should recommend the defaults (buffering=on). Resolves #115 Signed-off-by: Ben Clark <ben@benjyc.uk>
ThomDietrich
pushed a commit
to ThomDietrich/openhab-docs
that referenced
this issue
Nov 8, 2016
SSEs are now supported through a proxy using buffering. IMHO we should recommend the defaults (buffering=on). Resolves openhab#115 Signed-off-by: Ben Clark <ben@benjyc.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The recent change in eclipse-archived/smarthome#2300 means that we can keep to defaults with openHAB in regards to proxy_buffering (on). This is usually used to free up backend servers in case of slow client connections.
I think the defaults for buffer sizes should be fine for most openHAB users, so this should be a simple case of removing the proxy_buffering line. But I want to test some options before putting in a PR and thought I'd make an issue in case I forget to do this.
The text was updated successfully, but these errors were encountered: