Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sitemaps.md #1149

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Update sitemaps.md #1149

merged 2 commits into from
Dec 10, 2020

Conversation

m0rgano
Copy link
Contributor

@m0rgano m0rgano commented Feb 1, 2020

Show an example of displaying an image from an IP camera.

Show an example of displaying an image from an IP camera.
@m0rgano m0rgano requested a review from ThomDietrich February 1, 2020 20:04
@netlify
Copy link

netlify bot commented Feb 1, 2020

✔️ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

🔨 Explore the source changes: 3222a6b

🔍 Inspect the deploy logs: https://app.netlify.com/sites/openhab-docs-preview/deploys/5fd286f63aa123000721798d

😎 Browse the preview: https://deploy-preview-1149--openhab-docs-preview.netlify.app

Copy link
Member

@ThomDietrich ThomDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @m0rgano,
your intention is to show the use of refresh? Good idea but this is not so clear from the example. I'd leave out the comment for simplicity but add "e.g. for webcam images" to the refresh description. For testing reasons I suggest to use a publicly available webcam link :) there are many for famous public places or even from the ISS. Not sure how to include them though. Maybe you can quickly try.

These are just suggestions, I don't want to hold back the PR. Let us know how you feel about my requests. Best!

@ghys ghys changed the base branch from master to 2.5.x February 10, 2020 17:54
@ghys
Copy link
Member

ghys commented Feb 10, 2020

Note: changed the base branch to 2.5.x which is the default for now, and will appear on the production website.
master is now the branch for openHAB 3.x docs.

@openhab/documentation-maintainers
Once this is merged to 2.5.x please remember to merge (for example, cherry-pick the commit) this to master as well if appropriate.
See #1133 for details.

@Confectrician
Copy link
Contributor

I am with @ThomDietrich here.
If refresh is the usecase here, we should promote this better.

@ghys ghys changed the base branch from 2.5.x to main September 21, 2020 15:18
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
@Confectrician Confectrician dismissed ThomDietrich’s stale review December 10, 2020 20:38

Fullfiled the request

@Confectrician Confectrician merged commit f327c79 into openhab:main Dec 10, 2020
@Confectrician Confectrician added this to the 3.0 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants