Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[developers.bindings.discovery.upnp] Describe getRemovalGracePeriodSeconds() method #1478

Merged
merged 2 commits into from
Feb 3, 2021
Merged

[developers.bindings.discovery.upnp] Describe getRemovalGracePeriodSeconds() method #1478

merged 2 commits into from
Feb 3, 2021

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Feb 2, 2021

Pull Request openhab/openhab-core#2144 is an extension to the UpnpDiscoveryParticipant interface, that declares an additional 'default' method getRemovalGracePeriodSeconds().

This Pull Request is an update to the binding developers guide that describes the background of that interface extension, and explains how it should (optionally) be implemented, with a code example.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

…ds()

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@netlify
Copy link

netlify bot commented Feb 2, 2021

Deploy preview for openhab-docs-preview failed.

Built with commit 0864af1

https://app.netlify.com/sites/openhab-docs-preview/deploys/60192db7ad08920008c7ccfd

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Copy link
Contributor Author

andrewfg commented Feb 2, 2021

I have no idea what to make of the Netlify errors. => Must I do something?

@Confectrician
Copy link
Contributor

I have no idea what to make of the Netlify errors. => Must I do something?

Nope.
We have some broken config for the preview builds in our repo, due to some structural changes.
This will resolve with merging the open ui pull request.

Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants