Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document about page info and settings #1892

Merged
merged 8 commits into from
Oct 2, 2022

Conversation

stefan-hoehn
Copy link
Contributor

@stefan-hoehn stefan-hoehn commented Sep 24, 2022

Signed-off-by: Stefan Höhn mail@stefanhoehn.com

Document information and settings on about page
Includes setting up and using web audio
Document configuration section

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn
Copy link
Contributor Author

@wborn @ghys

Do you mind reviewing what I have written?

@netlify
Copy link

netlify bot commented Sep 24, 2022

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 47d4758
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/633949e805b7250008cf0fff
😎 Deploy Preview https://deploy-preview-1892--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small markdown comments from my side.
I can commit those later.

settings/aboutpage.md Outdated Show resolved Hide resolved
settings/aboutpage.md Outdated Show resolved Hide resolved
stefan-hoehn and others added 2 commits September 29, 2022 20:03
Co-authored-by: Jerome Luckenbach <github@luckenba.ch>
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to have some docs for this. 👍

@Confectrician Confectrician merged commit 4cf51ae into openhab:main Oct 2, 2022
@stefan-hoehn stefan-hoehn deleted the settings_menu_aboutpage branch October 8, 2022 13:00
@ghys
Copy link
Member

ghys commented Oct 11, 2022

@stefan-hoehn
Copy link
Contributor Author

@ghys Thanks a lot, I have definitely checked it in the beginning but I then seemed to completely have screwed it up. I already fixed it and I will soon push. I always appreciate four eyes!

@stefan-hoehn
Copy link
Contributor Author

I created a new PR for that: #1902

@Confectrician Confectrician added this to the 3.4 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants