Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo OH3 breaking changes link workaround #2110

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Jul 31, 2023

These breaking changes were added to the OH3 release notes again recently (openhab/openhab-distro#1339).

@netlify
Copy link

netlify bot commented Jul 31, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 3ba7671
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/64ccb1d04823c2000822d33c
😎 Deploy Preview https://deploy-preview-2110--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wborn wborn closed this Aug 2, 2023
@wborn wborn reopened this Aug 2, 2023
@stefan-hoehn
Copy link
Contributor

@Confectrician @wborn Any idea why the cherry pick doesn't work?

These breaking changes were added to the OH3 release notes again recently (openhab/openhab-distro#1339).

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Copy link
Member Author

wborn commented Aug 4, 2023

It seems happier after rebasing this PR. Though there weren't any conflicts. It could also have been some Netlify issue.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the clarification and the doc update, Wouter.
LGTM.

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Aug 7, 2023
@stefan-hoehn stefan-hoehn merged commit 3e452c5 into openhab:main Aug 7, 2023
5 checks passed
@wborn wborn deleted the remove-workaround branch August 7, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants