Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items: Fix mention of tag name and temperature tag example #2315

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jun 20, 2024

No description provided.

Copy link

netlify bot commented Jun 20, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 278e44c
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/66813fe594e6670008ae7e07
😎 Deploy Preview https://deploy-preview-2315--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jlaur jlaur changed the title Items: Fix mention of tag name Items: Fix mention of tag name and temperature tag example Jun 23, 2024
@jlaur
Copy link
Contributor Author

jlaur commented Jun 23, 2024

I don't understand this failure:

Error: developers/bindings/index.md:980:103 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

Is it related to this PR, or some general issue?

@lolodomo
Copy link
Contributor

lolodomo commented Jun 29, 2024

Changes look good to me.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thx

@stefan-hoehn stefan-hoehn self-requested a review June 30, 2024 11:21
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@stefan-hoehn stefan-hoehn merged commit 16f8b62 into openhab:main Jun 30, 2024
5 checks passed
@jlaur jlaur deleted the items-light branch June 30, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants