Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QNAP installation instructions #2377

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

moodyblue
Copy link
Contributor

@moodyblue moodyblue commented Sep 29, 2024

Create install instructions for QNAP NAS. Fixes #2371

Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Copy link

netlify bot commented Sep 29, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 20082cc
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/66fc7c1f0434c6000840e95f
😎 Deploy Preview https://deploy-preview-2377--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
@moodyblue
Copy link
Contributor Author

Link to Z2M site has been removed as required by the failing run.

@stefan-hoehn
Copy link
Contributor

Please add a description to the PR and add the following to it:

Fixes #2371

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigado, thanks for the contribution, see my comments on the text.

installation/qnap.md Outdated Show resolved Hide resolved
installation/qnap.md Outdated Show resolved Hide resolved
installation/qnap.md Outdated Show resolved Hide resolved
installation/qnap.md Outdated Show resolved Hide resolved
installation/qnap.md Outdated Show resolved Hide resolved
installation/qnap.md Outdated Show resolved Hide resolved
@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Sep 30, 2024
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
@moodyblue
Copy link
Contributor Author

I've also added a new section "Manual Update"

Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
@stefan-hoehn
Copy link
Contributor

@kaikreuzer

While talking with @florian-h05 today we were wondering if we should document how a package that is not provided by us should be part of our documentation?

As the following is not our distro

See https://www.myqnap.org/product/openhab/

I wonder if the written documentation of @moodyblue shouldn't rather go there?

(sorry @moodyblue for the late insight)

@moodyblue
Copy link
Contributor Author

moodyblue commented Oct 1, 2024

I understand. While it's possible to install JDK17 in QNAP and perform a manual install using the official repo this is far more complex. But I can write such instructions if you prefer.

You may also notice that in the meantime I've added instructions to replace MyQNAP's distribution with your distribution, so there is always an option to "revert to oficial distriburion" while preserving the normal way that packages are executed in QNAP systems.

I'm Ok with any decision you make. Unfortunately it's not possible to document the installation with high detail in MyQNAP repo.

Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
Signed-off-by: moodyblue <hugo.castelobranco@gmail.com>
@moodyblue
Copy link
Contributor Author

@stefan-hoehn @kaikreuzer Can you pls let me know what to do ?

@stefan-hoehn
Copy link
Contributor

@kaikreuzer Can you please have a look at this, Kai?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installation Guide] QNAP NAS
2 participants