Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkchecker script, result and badges #566

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Add linkchecker script, result and badges #566

merged 2 commits into from
Nov 29, 2017

Conversation

ThomDietrich
Copy link
Member

@ThomDietrich ThomDietrich commented Nov 14, 2017

A first implementation for #565

For now only covers the check for broken links based on linkchecker. A script is provided to execute, it will execute linkchecker against the public page, then store an html report and update badges in README.md. Currently the results will need to be committed, that could be avoided whenever #520 is reconsidered.

I'll add the remark linting process in a later PR.

The included report was created with LinkChecker 8.6
I am waiting for the soon to be available pypi release from: https://github.com/linkcheck/linkchecker/releases/tag/v9.3.1

Signed-off-by: Thomas Dietrich Thomas.Dietrich@tu-ilmenau.de

grafik

Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

I will do a test too and approve then.

@ThomDietrich
Copy link
Member Author

ThomDietrich commented Nov 15, 2017

@Confectrician you don't have to hurry testing. I'll add a better version of the LinkChecker results and append the remark tests soon. The script is basically working and if there is a bug somewhere it will pop up soon enough.

Note to myself: Maybe add a badge/text to inform about the last update date

@ThomDietrich
Copy link
Member Author

Merging to have a first version out there. Follow-up PRs will come.

@kaikreuzer from now on, please execute the script alongside update-external-resources.sh. Thanks!

@ThomDietrich ThomDietrich merged commit 2535787 into gh-pages Nov 29, 2017
@ThomDietrich ThomDietrich deleted the checkers branch November 29, 2017 13:48
@kaikreuzer
Copy link
Member

Will try to remember :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants