Remove the github handle references from the Contributing Page. #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note regarding the signoff switch for git. Signed-off-by: Stewart Cossey <stewart.cossey@gmail.com>
|
Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits). Built with commit 7b37bdb https://deploy-preview-919--openhab-docs-preview.netlify.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As DCO does not work with github handles in signoff I have removed the handle references from the signing section in the docs contributing page. I have also made a note regarding the signoff switch for git.
PRs this was mentioned in:
openhab/openhab-core#663 (comment)
https://github.com/openhab/openhab2-addons/pull/5116#issuecomment-473523270
@cweitkamp
Signed-off-by: Stewart Cossey stewart.cossey@gmail.com