[Current Beta]: App ignores user-defined icons

[Boby71]

Describe the bug
I do use custom icons (PNG format) and they are displayed correctly in the web interface. But not in the app. It almost looks like that the app ignores user-defined icons in the app - but not all of them, only certain (maybe if there is a predefined icon available?)

To Reproduce
Steps to reproduce the behavior:
Try to use custom icons for a) elements which have predefined icons (e.g. "alarm") and b) for items which don't have predefined icons (e.g. "pool")

Expected behavior
I expect the app to render the same icons as I can see in the web frontend

Screenshots

Desktop (please complete the following information):

• Version 2.4.0-1

Smartphone (please complete the following information):

• Device: iPhone8

Additional context
It does seem to be a general problem - no matter if I use dark mode or not.
"Clear image" cache didn't help.

[timbms]

I suppose that the icons are black with a transparent background. Resulting in pitch black icon fields when displayed in dark mode. Currently app in dark mode does not call themed icons.
Likely the web app request the icons in a dark theme (This is actually what is done in Charts).

[timbms]

Or it would require inverting images:
http://codingpills.ioneanu.com/swiftui-handling-images-in-dark-theme/
Likely this makes only sense for b/w images.
https://github.com/onevcat/Kingfisher/wiki/Cheat-Sheet#creating-a-processor-from-cifilter

[timbms]

@Boby71 : Can you please upload one of your icons as an example?

[Boby71]

Hi,
it gets even better...on this screen I use four different items - and all of them have the icon "meter" defined. Three of them are being displayed correctly, one (the third meter icon) is being displayed differntly:

Here's my "meter" icon:
meter.zip

Thanks,
Boby

[Boby71]

Here's the item definition:

// Waschmaschine
Switch Waschmaschine_Status "Power [%s]" {channel="mqtt:topic:mosquitto:shellyplug_waschmaschine:power"}
Number Waschmaschine_Watt_Aktuell "Verbrauch WM aktuell [%.1f W]" (gHaushaltsgeraete) {channel="mqtt:topic:mosquitto:shellyplug_waschmaschine:watts"}
Number Waschmaschine_Watt_Info {channel="mqtt:topic:mosquitto:shellyplug_waschmaschine:watts"}
Number Waschmaschine_Verbrauch {channel="mqtt:topic:mosquitto:shellyplug_waschmaschine:energy"}
Number Waschmaschine_Verbrauch_kWh "Verbrauch WM kummuliert [%.1f kWh]"

// Trockner
Switch Trockner_Status "Power [%s]" {channel="mqtt:topic:mosquitto:shellyplug_trockner:power"}
Number Trockner_Watt_Aktuell "Verbrauch TR aktuell [%.1f W]" (gHaushaltsgeraete) {channel="mqtt:topic:mosquitto:shellyplug_trockner:watts"}
Number Trockner_Watt_Info {channel="mqtt:topic:mosquitto:shellyplug_trockner:watts"}
Number Trockner_Verbrauch {channel="mqtt:topic:mosquitto:shellyplug_trockner:energy"}
Number Trockner_Verbrauch_kWh "Verbrauch TR kummuliert [%.1f kWh]"

And here's the sitemap:

Text item=Dummy label="Haushaltsgeräte" icon="Waschmaschine"
{
// Waschküche Keller
Text item=Dummy label="Waschküche" icon="Waschmaschine"
{
Frame label="Waschmaschine" icon="Waschmaschine"
{
Switch item=Waschmaschine_Status mappings=[ON="ON",OFF="OFF"]
Text item=Waschmaschine_Watt_Aktuell
Text item=Waschmaschine_Verbrauch_kWh
}
Frame label="Trockner" icon="Trockner"
{
Switch item=Trockner_Status mappings=[ON="ON",OFF="OFF"]
Text item=Trockner_Watt_Aktuell
Text item=Trockner_Verbrauch_kWh
}
Frame label="Diagramm"
{
Switch item=ChartScale10 label="Zeitraum" mappings=[1="H", 2="T", 3="W", 4="M", 5="Y"] icon="chart"
Chart item=gHaushaltsgeraete period=h refresh=10000 service="rrd4j" visibility=[ChartScale10==1, ChartScale10==NULL]
Chart item=gHaushaltsgeraete period=D refresh=600000 service="rrd4j" visibility=[ChartScale10==2]
Chart item=gHaushaltsgeraete period=W refresh=3600000 service="rrd4j" visibility=[ChartScale10==3]
Chart item=gHaushaltsgeraete period=M refresh=604800000 service="rrd4j" visibility=[ChartScale10==4]
Chart item=gHaushaltsgeraete period=Y refresh=864000000 service="rrd4j" visibility=[ChartScale10==5]
}
}
}

[Boby71]

Sorry for the format, for some reason the formatter doesn't recognize my code as code...

[Boby71]

Additional hint: The app only provides the wrong icons when being used on groups (text {} or frame{} level) AND when there is a default smarthome icon available (e.g. "alarm" or "camera"). If there is no (embedded?) default icon, the app displays the correct (user provided) icon. When I use e.g. "camera1" as name for my PNG file, everything works as expected. When I use "camera", the wrong display is being displayed.

[timbms]

Well that's strange. iOS app should ignore icons defined for frames.
if widget?.icon != nil, !((cell is NewImageUITableViewCell) || (cell is VideoUITableViewCell) || (cell is FrameUITableViewCell) || (cell is WebUITableViewCell)) {

Also OpenHAB is very clear:

Users may substitute their own icon for an icon from the default icon set by placing a file in the $OPENHAB_CONF/icons/classic/ folder with the same filename as the name of the icon being substituted.

Simple solution for user-defined icons: let them have a different name to the standard names.

[Boby71]

You're right - my mistake, frames don't work. Sorry about that. But on grouping items the problem is still existing.

Is there somewhere a list of those "predefined" icons and which names I have to avoid? I wasn't aware are some at all, since they are not visible in the icons folder where I can place my personal ones.

Personally, I have no problem in using different names for my icons - it's exactly what I'm doing now (e.g. "camera1" instead of "camera") as workaround. But that doesn't explain the different behaviour between the web GUI and the app GUI. IMHO OH2 should render the GUI as similar as possible. And showing different icons is not similar (at least for me).

If you want, I can close this thread - when I've changed all my affected icon names, my problem will be solved for me.

[weakfl]

https://www.openhab.org/docs/configuration/iconsets/classic/

[weakfl]

Maybe this was just a caching issue (replacing stock icons). I noticed that the the "Clear Image Cache" setting was broken and didn't do anything.

[timbms]

@weakfl : Can we close this issue?

[weakfl]

I think so. We can still re-open if required.

[weakfl]

@timbms Did you re-open on purpose?

[timbms]

No probably a mistake