Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #734 #735

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Fixes #734 #735

merged 5 commits into from
Oct 31, 2023

Conversation

timbms
Copy link
Contributor

@timbms timbms commented Oct 21, 2023

  • Migrate trustedCertificates from [String: Any] to [String: Data]
  • saveTrustedCertificate() writes with PropertyListEncoder instead of NSKeyedArchiver
  • loadTrustedCertificates() attempts first decoding with PropertyListDecoder() if error is thrown it unarchives with NSKeyedUnarchiver()

timbms and others added 2 commits October 21, 2023 18:00
Migrate trustedCertificates from [String: Any] to [String: Data]
saveTrustedCertificate() writes with PropertyListEncoder instead of NSKeyedArchiver
loadTrustedCertificates() attempts first decoding with PropertyListDecoder() if error is thrown it unarchives with NSKeyedUnarchiver()

Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
@timbms timbms merged commit 0f024fe into develop Oct 31, 2023
1 of 2 checks passed
@timbms timbms deleted the FixFor734-unarchiveTopLevelObjectWithData branch October 31, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants