Eliminate DynamicButton #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Müller-Seydlitz <timbms@gmail.com>
Signed-off-by: Tim Müller-Seydlitz <timbms@gmail.com>
|
I like to use SFSafeSymbols for type safe symbols. It's all too easy to use a symbol that's not available on the deployment target. |
|
Nice cleanup ! I'll take a look in the next day or 2. |
Very valid point. |
|
Followed @weakfl's suggestion. Quite a few places where the string based interface is used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openhab-ios is relying on https://github.com/yannickl/DynamicButton for symbols.
With update to at least iOS 13, we can migrate to SF Symbols.