Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guards against creating very large UImages from SVGs #818

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Guards against creating very large UImages from SVGs #818

merged 2 commits into from
Sep 15, 2024

Conversation

digitaldan
Copy link
Contributor

Fixes #817

timbms
timbms reviewed Sep 15, 2024
View reviewed changes
Copy link
Contributor

@timbms timbms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of taking the image from the images catalogue, we could use SF Symbol.
return UIImage(systemSymbol: .exclamationmarkTriangleFill).foregroundColor(.orange)
and get red of the entry in the images catalogue

@digitaldan
Guards against creating very large UImages from SVGs
f7948d1 
Fixes openhab#817

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
remove error.png, use sys icon
2a97feb 
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan digitaldan merged commit d3efa53 into openhab:develop Sep 15, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbms timbms timbms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVG Images in sitemaps exhausting memory and crashing
2 participants
@digitaldan @timbms