Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Automatic Signing #828

Merged
merged 13 commits into from
Sep 18, 2024
Merged

No Automatic Signing #828

merged 13 commits into from
Sep 18, 2024

Conversation

timbms
Copy link
Contributor

@timbms timbms commented Sep 17, 2024

No description provided.

@digitaldan
Copy link
Contributor

Were you able to test this with fastlane ? I was having some signing issues yesterday and was toggling this on and off in xcode, but i was not sure if this was an issue with my local setup or not.

@weakfl
Copy link
Contributor

weakfl commented Sep 18, 2024

I was having some signing issues yesterday and was toggling this on and off in xcode

This is definitely an issue. Manual signing (for release builds) is mandatory for fastlane. So better to leave this untouched.

To set up manual signing correctly you'll need to download the certs/profiles via fastlane match first.

I could take a look but am currently on vacation.

Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
timbms and others added 2 commits September 18, 2024 13:53
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Anka <runner@Mac-1726659622873.local>
@timbms
Copy link
Contributor Author

timbms commented Sep 18, 2024

I could take a look but am currently on vacation.

Thank you @weakfl for offering your rescue services. I got it working. With update_code_signing_settings I am overwriting the setup in the front-end! Was successful in uploading . Enjoy your vacation.

timbms and others added 2 commits September 18, 2024 14:29
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
Signed-off-by: Anka <runner@Mac-1726663922704.local>
@digitaldan
Copy link
Contributor

I could take a look but am currently on vacation.

You should enjoy your vacation ;-)

I got it working. With update_code_signing_settings I am overwriting the setup in the front-end! Was successful in uploading

Awesome !

@timbms
Copy link
Contributor Author

timbms commented Sep 18, 2024

@digitaldan the actions prove it is working. You can merge it IMO

@digitaldan digitaldan merged commit cb495b5 into develop Sep 18, 2024
2 checks passed
@digitaldan digitaldan deleted the noAutomaticSigning branch September 18, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants