Sitemap Builder

[ccutrer]

No description provided.

[jimtng]

With items.build:

items.build do
  switch_item MySwitch, "My Switch"
end

Should we make sitemaps.build similar to items builder syntax:

    sitemaps.build do
      sitemap "default", "My Residence" do
        text Switch1, "Label"
      end
    end

[ccutrer]

I thought about that, but with items a name is required, and label is optional, but very common. With sitemaps, both item and label are optional, and it's just as likely that one will be omitted as the other... erego I couldn't choose either as the less common one to place second as a positional parameter. Also, the regular sitemap syntax has both as essentially named parameters, so using keyword arguments for both maps more closely to that.

[jimtng]

We could use *args and check if it's a Proxy, then it's the item, if it's String, it's the label. The rest (icon, etc) can stay as kwargs. This is just a suggestion / idea, in case you hadn't considered it. Happy to stick to kwargs too.

I also noticed that sitemap takes two non-kwargs, i.e. sitemap "name", "label" whereas openhab syntax uses label= named parameter.

Strictly adhering to the sitemap file syntax may become irrelevant if one day openhab switched to yaml, although this may never actually happen.

[ccutrer]

heh, yeah, for sitemap, the name is required, so I made it like items. Also, I can't necessarily do item/proxy detection, since String is a valid datatype for the item (same as for Items builder - you can use an Item, or a String).

[jimtng]

Thanks! This is an awesome feature!