Adjust specs for OH4.1 QuantityType changes #145
Conversation
jimtng
force-pushed
the
fix-quantity-specs
branch
from
469a4a6 to
0a1da88
Compare
| @@ -11,7 +11,8 @@ | |||
| # quantity type operand | |||
| expect(QuantityType.new("50 °F") + QuantityType.new("50 °F")).to eql QuantityType.new("100.0 °F") | |||
| expect(QuantityType.new("50 °F") - QuantityType.new("25 °F")).to eql QuantityType.new("25.0 °F") | |||
| expect((QuantityType.new("100 °F") / QuantityType.new("2 °F")).to_i).to be 50 | |||
| # @deprecated OH4.0 result of 50. OH 4.1 will result in 1. see https://github.com/openhab/openhab-core/pull/3792 | |||
| expect((QuantityType.new("100 °F") / QuantityType.new("2 °F")).to_i).to be(50).or be(1) | |||
There was a problem hiding this comment.
If I try this with the DSL, I get 1.212272835575194402928498711200641256820715734904441123168785784940181676 as a result (which is the division of the absolute Kelvin values of the 2 temperatures). Is it a characteristic of jruby this will round to 1? 1 definitely is not logical.
There was a problem hiding this comment.
It rounds it to 1 because of the call to_i which converts it to integer.
There was a problem hiding this comment.
Then it is maybe better to select other values as input, as this rounding can create a false impression, and is quite meaningless as a test.
There was a problem hiding this comment.
Since we're not verifying the actual behavior of relative vs absolute units, I'm just going to avoid using temperature units in this particular test. We only need to verify that multiplication / division can be done without having to verify the implementation details.
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
fix-quantity-specs
branch
from
0a1da88 to
501445e
Compare
|
Superseded by #147 |
See openhab/openhab-core#3792