Tweak Rule ID inference to work with F7 router #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Framework7 doesn't like dots in the dynamic route path. Accessing the script using the url /settings/scripts/filename.rb:xx will result in a 404 because no route would match. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
rule-id-inference
branch
from
0ef6a68 to
7ef92f2
Compare
jimtng
commented
Mar 3, 2024
| rule "log test" do | ||
| on_load | ||
| run do | ||
| after(1.second) do | ||
| executed = true | ||
| expect(logger.name).to match(/^org\.openhab\.automation\.jrubyscripting\.rule\.log_spec\.rb:(?:\d+)$/) |
There was a problem hiding this comment.
When this expectation isn't met, an exception(?) is raised inside the timer. This somehow caused the whole rspec not to complete. It would time out after about 7 minutes. So I've moved it outside the timer.
There was a problem hiding this comment.
well that sounds like something interesting to investigate, to prevent possible hanging builds in the future ;)
ccutrer
approved these changes
Mar 5, 2024
| rule "log test" do | ||
| on_load | ||
| run do | ||
| after(1.second) do | ||
| executed = true | ||
| expect(logger.name).to match(/^org\.openhab\.automation\.jrubyscripting\.rule\.log_spec\.rb:(?:\d+)$/) |
There was a problem hiding this comment.
well that sounds like something interesting to investigate, to prevent possible hanging builds in the future ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework7 doesn't like dots in the dynamic route path.
Accessing the script using the url /settings/scripts/filename.rb:xx will result in a 404 because no route would match.