Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in Buttongrid: call create_button_definition in OH4.2 #270

Merged
merged 1 commit into from
May 21, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented May 21, 2024

This is to adapt to the change in core: openhab/openhab-core#4223

A separate PR will be created to add support for the new Button widget

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng added the bug Something isn't working label May 21, 2024
@jimtng
Copy link
Contributor Author

jimtng commented May 21, 2024

Note, bundler-multilock 1.3.2 caused a problem with jruby

Fetching bundler-multilock 1.3.2
Installing bundler-multilock 1.3.2
Failed to install plugin `bundler-multilock`, due to
Bundler::Plugin::MalformattedPlugin (RuntimeError: ObjectSpace is disabled;
each_object will only work with Class, pass -X+O to enable)
Error: The process '/home/runner/.rubies/jruby-9.4.7.0/bin/bundle' failed with exit code 29

https://github.com/openhab/openhab-jruby/actions/runs/9177484986/job/25239928255

temporarily sticking with 1.2.x for now. Probably fine using 1.3.1 though.

@jimtng jimtng requested a review from ccutrer May 21, 2024 17:54
@jimtng jimtng force-pushed the buttongrid-buttons-oh42 branch from eb5557d to f5e714e Compare May 21, 2024 19:21
@jimtng
Copy link
Contributor Author

jimtng commented May 21, 2024

removed the commit that dropped bundle-multilock to version 1.2.x because it's now pinned to 1.3.1 in another commit

@ccutrer ccutrer merged commit efe760a into openhab:main May 21, 2024
30 of 35 checks passed
@jimtng jimtng deleted the buttongrid-buttons-oh42 branch May 21, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants