Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support space separator between date and time #329

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Sep 7, 2024

Support DateTimeType.new("2020-01-01 12:30") as well as DateTimeItem1.update("2020-01-01 12:30") for all versions of openHAB.

See: openhab/openhab-core#4370 and DateTimeType also supports parsing a string containing epoch, so let it try parsing the string too.

@jimtng jimtng added the enhancement New feature or request label Sep 7, 2024
@jimtng
Copy link
Contributor Author

jimtng commented Sep 7, 2024

Spec failed because it needs #328 (nothing to do with this PR)

@jimtng jimtng requested a review from ccutrer September 7, 2024 03:07
@jimtng jimtng force-pushed the datetimetype-space branch from 02c241a to 0202b88 Compare September 7, 2024 03:33
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the datetimetype-space branch from 0202b88 to a74e0ae Compare September 8, 2024 15:03
@ccutrer ccutrer merged commit f581a49 into openhab:main Sep 8, 2024
21 checks passed
@jimtng jimtng deleted the datetimetype-space branch September 9, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants