Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timed command expire #337

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix timed command expire #337

merged 1 commit into from
Sep 16, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Sep 16, 2024 •
edited
Loading

Regression from #312

There were two problems

  • When timed command expired, the cancel rule got called because it wasn't disabled
  • In the timed command block, it was possible to call resume when the timed command had expired, resulting in an expired timed command that isn't cleaned up / removed.

@jimtng jimtng added the bug Something isn't working label Sep 16, 2024
@jimtng jimtng requested a review from ccutrer September 16, 2024 00:22
@jimtng jimtng force-pushed the timed-command-expire-fix branch 2 times, most recently from b1e933b to 4efee18 Compare September 16, 2024 01:04
@jimtng
Fix timed command expire
e0ecd4e 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the timed-command-expire-fix branch from 4efee18 to e0ecd4e Compare September 16, 2024 01:17
@ccutrer ccutrer merged commit d8f0e9e into openhab:main Sep 16, 2024
21 checks passed
@jimtng jimtng deleted the timed-command-expire-fix branch September 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccutrer ccutrer ccutrer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimtng @ccutrer