-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[things] Add Thing class & Get Thing(s) #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-h05
force-pushed
the
retrieve-all-things
branch
from
June 3, 2022 22:14
9b4ebec
to
0de3dfa
Compare
The Thing class represents an openHAB Thing. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
retrieve-all-things
branch
from
June 3, 2022 22:17
0de3dfa
to
eb0d8c8
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
[WIP][things] Add Thing class & Get Thing(s)
[things] Add Thing class & Get Thing(s)
Jun 3, 2022
digitaldan
approved these changes
Jun 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Jun 5, 2022
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
digitaldan
pushed a commit
that referenced
this pull request
Jun 5, 2022
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Jun 19, 2022
This adds the `things` namespace with the `Thing` class and the Thing getter methods. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89.
Improvements
Thing
class which represents an openHAB Thing, that e.g. holds the label, but also allows to set the enabled stategetThings
to get an Array of all openHAB ThingsgetThing
to get a single ThingTesting
DO NOT USE ON PRODUCTION AS THIS MODIFIES A THING!!