Add DateTime trigger
#154
Merged
Add DateTime trigger
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the DateTime trigger, which was added in openhab/openhab-core#2726. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
add-datetime-trigger
branch
from
c729e79 to
5d67dba
Compare
digitaldan
approved these changes
Aug 23, 2022
| @@ -22,8 +23,8 @@ | |||
| * @property {string} oldStatus only for {@link triggers.ThingStatusChangeTrigger}: Previous state of Thing that triggered event | |||
| * @property {string} newStatus only for {@link triggers.ThingStatusChangeTrigger}: New state of Thing that triggered event | |||
| * @property {string} status only for {@link triggers.ThingStatusUpdateTrigger}: State of Thing that triggered event | |||
| * @property {string} eventType for all triggers except {@link triggers.PWMTrigger}, {@link triggers.PIDTrigger}: Type of event that triggered event (change, command, time, triggered, update) | |||
| * @property {string} triggerType for all triggers except {@link triggers.PWMTrigger}, {@link triggers.PIDTrigger}: Type of trigger that triggered event (for `TimeOfDayTrigger`: `GenericCronTrigger`) | |||
| * @property {string} eventType for all triggers except {@link triggers.PWMTrigger}, {@link triggers.PIDTrigger}, time triggers: Type of event that triggered event (change, command, time, triggered, update) | |||
There was a problem hiding this comment.
when we say "time triggers", do we mean TimeOfDayTrigger and DateTimeTrigger? If so, should we just call those out directly ?
There was a problem hiding this comment.
We mean all three time triggers that we have:
TimeOfDayTriggerGenericCronTriggerDateTimeTrigger
Therefore, it is saving some space to just say time trigger, and if there are added any more time triggers in the future, we do not have to update the docs.
|
@digitaldan |
|
sorry, yes i'm fine, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153.
This adds support for the DateTime trigger, which was added in
openhab/openhab-core#2726.